-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ZLibStream and fix SocketsHttpHandler deflate support #42717
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/ncl |
src/libraries/Common/tests/System/IO/Compression/CompressionStreamUnitTestBase.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Show resolved
Hide resolved
fb7b37a
to
0a43f93
Compare
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Decompression.cs
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Show resolved
Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/DecompressionHandler.cs
Show resolved
Hide resolved
0a43f93
to
9447f0f
Compare
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/DecompressionHandler.cs
Show resolved
Hide resolved
9447f0f
to
17eedcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some minor documentation suggestions to consider.
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression/src/System/IO/Compression/ZLibStream.cs
Show resolved
Hide resolved
One of the CI failures is:
There are also some System.Net.Http failures, not sure if related to the changes here: For example (the spanish error message says "operacion anulada" which means "aborted operation"):
|
cc8d4d6
to
bc948e8
Compare
- Implements ZLibStream, exposes it in the ref, and add tests - Fixes SocketsHttpHandler to use ZLibStream instead of DeflateStream
Co-authored-by: Carlos Sanchez <[email protected]>
bc948e8
to
cb7442a
Compare
@stephentoub you removed the breaking change labels ... is that because you implemented the detection that accepts both? |
Correct. |
Fixes #2236
Fixes #38022
(This completes the commit from #2236 (comment).)
The tests require the updated runtime-assets test data from dotnet/runtime-assets#87.
cc: @ericstj @carlossanlop @geoffkizer